refactor changeset icon and style

src/c3nav/editor/models/changeset.py

@@ -373,3 +373,31 @@ class ChangeSet(models.Model):
         super().save(*args, **kwargs)
         if self._request is not None:
             self.activate(self._request)
+
+    STATE_ICONS = {
+        'unproposed': 'pencil',
+        'proposed': 'send',
+        'reproposed': 'send',
+        'review': 'hourglass',
+        'rejected': 'remove',
+        'finallyrejected': 'remove',
+        'applied': 'ok',
+    }
+
+    @property
+    def icon(self):
+        return self.STATE_ICONS[self.state]
+
+    STATE_STYLES = {
+        'unproposed': 'mute',
+        'proposed': 'info',
+        'reproposed': 'info',
+        'review': 'info',
+        'rejected': 'danger',
+        'finallyrejected': 'danger',
+        'applied': 'success',
+    }
+
+    @property
+    def style(self):
+        return self.STATE_STYLES[self.state]

src/c3nav/editor/templates/editor/fragment_changesets.html

@@ -4,17 +4,7 @@
     {% for changeset in changesets %}
         <tr>
             <td>
-                {% if changeset.state == 'unproposed' %}
+                <i class="glyphicon glyphicon-{{ changeset.icon }} text-{{ changeset.style }}" title="{{ changeset.get_state_display }}" data-toggle="tooltip" data-placement="right"></i>
-                    <i class="glyphicon glyphicon-pencil text-muted" title="{{ changeset.get_state_display }}" data-toggle="tooltip" data-placement="right"></i>
-                {% elif changeset.state == 'proposed' or changeset.state == 'reproposed' %}
-                    <i class="glyphicon glyphicon-send text-info" title="{{ changeset.get_state_display }}" data-toggle="tooltip" data-placement="right"></i>
-                {% elif changeset.state == 'review' or changeset.state == 'rereview' %}
-                    <i class="glyphicon glyphicon-hourglass text-info" title="{{ changeset.get_state_display }}" data-toggle="tooltip" data-placement="right"></i>
-                {% elif changeset.state == 'rejected' or changeset.state == 'finallyrejected' %}
-                    <i class="glyphicon glyphicon-remove text-danger" title="{{ changeset.get_state_display }}" data-toggle="tooltip" data-placement="right"></i>
-                {% elif changeset.state == 'applied' %}
-                    <i class="glyphicon glyphicon-ok text-success" title="{{ changeset.get_state_display }}" data-toggle="tooltip" data-placement="right"></i>
-                {% endif %}
             </td>
             <td>{% if changeset.title %}{{ changeset.title }}{% else %}<em>#{{ changeset.id }} {% trans '(no title)' %}</em>{% endif %}</td>
             <td><a href="{% url 'editor.changesets.detail' pk=changeset.pk %}">{% trans 'Details' %}</a></td>