From 03018a2f46e8537baae798900c111e372f347d28 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laura=20Kl=C3=BCnder?= <laura@codingcatgirl.de>
Date: Mon, 25 Dec 2017 17:42:30 +0100
Subject: [PATCH] avoid pickle load errors while processupdates is running

---
 src/c3nav/mapdata/models/update.py |  4 ++--
 src/c3nav/routing/locator.py       | 29 ++++++++++++++++++++++++++---
 src/c3nav/routing/router.py        | 22 +++++++++++++---------
 3 files changed, 41 insertions(+), 14 deletions(-)

diff --git a/src/c3nav/mapdata/models/update.py b/src/c3nav/mapdata/models/update.py
index 5c3f2d88..674fad55 100644
--- a/src/c3nav/mapdata/models/update.py
+++ b/src/c3nav/mapdata/models/update.py
@@ -156,11 +156,11 @@ class MapUpdate(models.Model):
 
             logger.info('Rebuilding router...')
             from c3nav.routing.router import Router
-            Router.rebuild()
+            Router.rebuild(new_updates[-1].to_tuple)
 
             logger.info('Rebuilding locator...')
             from c3nav.routing.locator import Locator
-            Locator.rebuild()
+            Locator.rebuild(new_updates[-1].to_tuple)
 
             for new_update in new_updates:
                 new_update.processed = True
diff --git a/src/c3nav/routing/locator.py b/src/c3nav/routing/locator.py
index 5b439b3d..a4147f20 100644
--- a/src/c3nav/routing/locator.py
+++ b/src/c3nav/routing/locator.py
@@ -2,6 +2,7 @@ import operator
 import os
 import pickle
 import re
+import threading
 from collections import deque, namedtuple
 from functools import reduce
 
@@ -9,7 +10,7 @@ from django.conf import settings
 from django.core.exceptions import ValidationError
 from django.utils.translation import ugettext_lazy as _
 
-from c3nav.mapdata.models import Space
+from c3nav.mapdata.models import MapUpdate, Space
 
 
 class Locator:
@@ -20,7 +21,7 @@ class Locator:
         self.spaces = spaces
 
     @classmethod
-    def rebuild(cls):
+    def rebuild(cls, update):
         stations = LocatorStations()
         spaces = {}
         for space in Space.objects.prefetch_related('wifi_measurements'):
@@ -30,9 +31,31 @@ class Locator:
             )
 
         locator = cls(stations, spaces)
-        pickle.dump(locator, open(cls.filename, 'wb'))
+        pickle.dump(locator, open(cls.build_filename(update), 'wb'))
         return locator
 
+    @classmethod
+    def build_filename(cls, update):
+        return os.path.join(settings.CACHE_ROOT, 'locator_%s.pickle' % MapUpdate.build_cache_key(*update))
+
+    @classmethod
+    def load_nocache(cls, update):
+        return pickle.load(open(cls.build_filename(update), 'rb'))
+
+    cached = None
+    cache_update = None
+    cache_lock = threading.Lock()
+
+    @classmethod
+    def load(cls):
+        from c3nav.mapdata.models import MapUpdate
+        update = MapUpdate.last_processed_update()
+        if cls.cache_update != update:
+            with cls.cache_lock:
+                cls.cache_update = update
+                cls.cached = cls.load_nocache(update)
+        return cls.cached
+
 
 class LocatorStations:
     def __init__(self):
diff --git a/src/c3nav/routing/router.py b/src/c3nav/routing/router.py
index cf2aab87..ec31fe91 100644
--- a/src/c3nav/routing/router.py
+++ b/src/c3nav/routing/router.py
@@ -45,7 +45,7 @@ class Router:
         return max(area.get_altitudes(point)[0] for area in areas if area.geometry_prep.intersects(point))
 
     @classmethod
-    def rebuild(cls):
+    def rebuild(cls, update):
         levels_query = Level.objects.prefetch_related('buildings', 'spaces', 'altitudeareas', 'groups',
                                                       'spaces__holes', 'spaces__columns', 'spaces__groups',
                                                       'spaces__obstacles', 'spaces__lineobstacles',
@@ -239,25 +239,29 @@ class Router:
             restriction.edges = np.array(restriction.edges, dtype=np.uint32).reshape((-1, 2))
 
         router = cls(levels, spaces, areas, pois, groups, restrictions, nodes, edges, waytypes, graph)
-        pickle.dump(router, open(cls.filename, 'wb'))
+        pickle.dump(router, open(cls.build_filename(update), 'wb'))
         return router
 
     @classmethod
-    def load_nocache(cls):
-        return pickle.load(open(cls.filename, 'rb'))
+    def build_filename(cls, update):
+        return os.path.join(settings.CACHE_ROOT, 'router_%s.pickle' % MapUpdate.build_cache_key(*update))
+
+    @classmethod
+    def load_nocache(cls, update):
+        return pickle.load(open(cls.build_filename(update), 'rb'))
 
     cached = None
-    cache_key = None
+    cache_update = None
     cache_lock = threading.Lock()
 
     @classmethod
     def load(cls):
         from c3nav.mapdata.models import MapUpdate
-        cache_key = MapUpdate.current_processed_cache_key()
-        if cls.cache_key != cache_key:
+        update = MapUpdate.last_processed_update()
+        if cls.cache_update != update:
             with cls.cache_lock:
-                cls.cache_key = cache_key
-                cls.cached = cls.load_nocache()
+                cls.cache_update = update
+                cls.cached = cls.load_nocache(update)
         return cls.cached
 
     def get_locations(self, location, restrictions):