From 0d310d337c37fd9f7c08431cd98a792e60ace274 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Laura=20Kl=C3=BCnder?= Date: Wed, 21 Jun 2017 19:11:08 +0200 Subject: [PATCH] fix an error for model inheritance in _filter_values --- src/c3nav/editor/wrappers.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/c3nav/editor/wrappers.py b/src/c3nav/editor/wrappers.py index b7c59e5f..b89e38db 100644 --- a/src/c3nav/editor/wrappers.py +++ b/src/c3nav/editor/wrappers.py @@ -459,10 +459,11 @@ class BaseQueryWrapper(BaseWrapper): for pk, new_value in other_values: (add_pks if check(new_value) else remove_pks).append(pk) created_pks = set() - for pk, values in chain(*(self._changeset.created_objects.get(model, {}).items() for model in submodels)): - field_name = getattr(model._meta.get_field(field_name), 'attname', field_name) - if check(getattr(self._changeset.get_created_object(self._obj.model, pk), field_name)): - created_pks.add(pk) + for model in submodels: + for pk, values in self._changeset.created_objects.get(model, {}).items(): + field_name = getattr(model._meta.get_field(field_name), 'attname', field_name) + if check(getattr(self._changeset.get_created_object(self._obj.model, pk), field_name)): + created_pks.add(pk) return (q & ~Q(pk__in=remove_pks)) | Q(pk__in=add_pks), created_pks