From 2566974ec54f303bb3dcc4343f0928e925a4f9ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Laura=20Kl=C3=BCnder?= Date: Mon, 10 Jul 2017 19:22:19 +0200 Subject: [PATCH] changeset view: dont treat False as empty --- src/c3nav/editor/templates/editor/changeset.html | 2 +- src/c3nav/editor/views/changes.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/c3nav/editor/templates/editor/changeset.html b/src/c3nav/editor/templates/editor/changeset.html index c45c0473..a298439f 100644 --- a/src/c3nav/editor/templates/editor/changeset.html +++ b/src/c3nav/editor/templates/editor/changeset.html @@ -109,7 +109,7 @@ {% if change.missing_dependency %}{% endif %} - {% if change.value %}{% else %}{% endif %}{{ change.title }}{% if change.value %}:{% else %}{% endif %} + {% if empty %}{% else %}{% endif %}{{ change.title }}{% if not empty %}:{% else %}{% endif %} {{ change.value }} diff --git a/src/c3nav/editor/views/changes.py b/src/c3nav/editor/views/changes.py index d9025e23..a4d18dae 100644 --- a/src/c3nav/editor/views/changes.py +++ b/src/c3nav/editor/views/changes.py @@ -297,8 +297,9 @@ def changeset_detail(request, pk): change_data.update({ 'order': (order, form_fields.index(name) if order else 1), }) - if not field_value: + if field_value == '' or field_value is None: change_data.update({ + 'empty': True, 'title': format_lazy(_('remove {field_title}'), field_title=field_title), }) else: