From 29e16e8ce0ec10440668b3f164cb4604ca8af356 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Laura=20Kl=C3=BCnder?= Date: Mon, 4 Dec 2023 22:31:00 +0100 Subject: [PATCH] remove more todo items --- src/c3nav/mapdata/api/mapdata.py | 2 -- src/c3nav/mapdata/schemas/filters.py | 2 +- src/c3nav/site/forms.py | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/c3nav/mapdata/api/mapdata.py b/src/c3nav/mapdata/api/mapdata.py index 09d14bcb..02bd1944 100644 --- a/src/c3nav/mapdata/api/mapdata.py +++ b/src/c3nav/mapdata/api/mapdata.py @@ -29,8 +29,6 @@ def mapdata_list_endpoint(request, model: Type[Model], filters: Optional[FilterSchema] = None, order_by: Sequence[str] = ('pk',)): - # todo: request permissions based on api key - # validate filters if filters: filters.validate(request) diff --git a/src/c3nav/mapdata/schemas/filters.py b/src/c3nav/mapdata/schemas/filters.py index 0cf032f5..ef54ccc6 100644 --- a/src/c3nav/mapdata/schemas/filters.py +++ b/src/c3nav/mapdata/schemas/filters.py @@ -151,7 +151,7 @@ class BySearchableFilter(FilterSchema): class RemoveGeometryFilter(FilterSchema): geometry: bool = APIField( - False, # todo: should be false + False, title='include geometry', description='by default, geometry will be ommited. set to true to include it (if available)' ) diff --git a/src/c3nav/site/forms.py b/src/c3nav/site/forms.py index 8c287d21..d95f21b4 100644 --- a/src/c3nav/site/forms.py +++ b/src/c3nav/site/forms.py @@ -89,7 +89,6 @@ class APISecretForm(ModelForm): class Meta: model = Secret fields = ['name', 'readonly', 'scope_grant_permissions', 'scope_editor', 'scope_mesh'] - # todo: allow suuplying days and hours def save(self, *args, **kwargs): self.instance.valid_until = (