2025-summer/team-3
12
Fork 0
Code Issues Pull requests Projects Releases Activity

avoid unnecessary queries in ModelInstanceWrapper.save

Browse source
This commit is contained in:
Laura Klünder 2017-06-13 23:31:37 +02:00
parent d3ffbd55cd
commit 5b3d6ffbc4
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/c3nav/editor/wrappers.py
View file

@ -164,13 +164,20 @@ class ModelInstanceWrapper(BaseWrapper):
if self.pk is None: if self.pk is None:
self._changeset.add_create(self, author=author) self._changeset.add_create(self, author=author)
for field, initial_value in self._initial_values.items(): for field, initial_value in self._initial_values.items():
new_value = getattr(self._obj, field.name) class_value = getattr(type(self._obj), field.name, None)
if field.related_model: if isinstance(class_value, ForwardManyToOneDescriptor):
try:
new_value = getattr(self._obj, class_value.cache_name)
except AttributeError:
new_value = getattr(self._obj, field.attname)
else:
new_value = None if new_value is None else new_value.pk new_value = None if new_value is None else new_value.pk
if new_value != initial_value: if new_value != initial_value:
self._changeset.add_update(self, name=field.name, value=new_value, author=author) self._changeset.add_update(self, name=field.name, value=new_value, author=author)
continue continue
new_value = getattr(self._obj, field.name)
if new_value == initial_value: if new_value == initial_value:
continue continue