2025-summer/team-3
12
Fork 0
Code Issues Pull requests Projects Releases Activity

nullable fields shouldn't use DummyValue

Browse source
This commit is contained in:
Laura Klünder 2024-11-29 16:11:23 +01:00
parent 9b6f61438a
commit 6c4a16fc45
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/c3nav/editor/changes.py
View file

@ -342,10 +342,10 @@ class ChangedObjectCollection(BaseSchema):
))
if not dependencies:
initial_fields[field_name] = None
initial_fields[field_name] = value
continue
initial_fields[field_name] = DummyValue
initial_fields[field_name] = None if field.null else DummyValue
obj_sub_operations.append(SingleOperationWithDependencies(
uid=(changed_obj.obj, f"field_{field_name}"),
operation=UpdateObjectOperation(obj=changed_obj.obj, fields={field_name: value}),
@ -566,10 +566,6 @@ class ChangedObjectCollection(BaseSchema):
if value is DummyValue:
# if there's a dummy value to fill, we need to find a dummy value
field = model_cls._meta.get_field(field_name)
if field.null:
# if it's nullable, we can just null it, todo: will it even be a dummy value then?
new_operation.fields[field_name] = None
continue
if field.is_relation:
# for a relation, we will try to find a valid other object to reference