From 791ff255d138168832a041642a68c6200120a71f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Laura=20Kl=C3=BCnder?= Date: Tue, 19 Dec 2017 00:56:12 +0100 Subject: [PATCH] one query less for rout description editing --- src/c3nav/editor/forms.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/c3nav/editor/forms.py b/src/c3nav/editor/forms.py index 64afdd8d..c31691c0 100644 --- a/src/c3nav/editor/forms.py +++ b/src/c3nav/editor/forms.py @@ -71,11 +71,13 @@ class EditorFormBase(I18nModelFormMixin, ModelForm): self.fields['access_restriction'].label_from_instance = lambda obj: obj.title self.fields['access_restriction'].queryset = AccessRestriction.qs_for_request(self.request) - Space = self.request.changeset.wrap_model('Space') - for space_field in ('origin_space', 'target_space'): - if space_field in self.fields: - self.fields[space_field].label_from_instance = lambda obj: obj.title - self.fields[space_field].queryset = Space.qs_for_request(self.request) + if 'target_space' in self.fields: + Space = self.request.changeset.wrap_model('Space') + space_qs = Space.qs_for_request(self.request) + for space_field in ('origin_space', 'target_space'): + if space_field in self.fields: + self.fields[space_field].label_from_instance = lambda obj: obj.title + self.fields[space_field].queryset = space_qs self.redirect_slugs = None self.add_redirect_slugs = None