2025-summer/team-3
12
Fork 0
Code Issues Pull requests Projects Releases Activity

check foreign keys for None before looking them up in changeset (fixes C3NAV-37C3-P)

Browse source
This commit is contained in:
Gwendolyn 2023-12-18 09:07:47 +01:00
parent a0078a6312
commit 79752f574c
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/c3nav/editor/views/changes.py
View file

@ -319,13 +319,16 @@ def changeset_detail(request, pk):
field = model._meta.get_field(name) field = model._meta.get_field(name)
field_title = field.verbose_name field_title = field.verbose_name
if field.related_model is not None: if field.related_model is not None:
if issubclass(field.related_model, User): if value is None:
field_value = objects[field.related_model][value].username field_value = None
else: else:
field_value = objects[field.related_model][value].title if issubclass(field.related_model, User):
change_data.update({ field_value = objects[field.related_model][value].username
'missing_dependency': field.name in missing_dependencies, else:
}) field_value = objects[field.related_model][value].title
change_data.update({
'missing_dependency': field.name in missing_dependencies,
})
else: else:
field_value = field.to_python(value) field_value = field.to_python(value)
if name in unique_collisions: if name in unique_collisions: