2025-summer/team-3
12
Fork 0
Code Issues Pull requests Projects Releases Activity

cleangeometries should delete objects with empty geometries

Browse source
This commit is contained in:
Laura Klünder 2019-12-24 00:51:35 +01:00
parent 735ad498ed
commit 9664b22a0c
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/c3nav/mapdata/fields.py
View file

@ -80,6 +80,7 @@ class GeometryField(models.TextField):
def _validate_geomtype(self, value, exception: typing.Type[Exception] = ValidationError): def _validate_geomtype(self, value, exception: typing.Type[Exception] = ValidationError):
if not isinstance(value, self.classes): if not isinstance(value, self.classes):
# if you get this error with wrappedgeometry, looked into wrapped_geom
raise exception('Expected %s instance, got %s instead.' % (' or '.join(c.__name__ for c in self.classes), raise exception('Expected %s instance, got %s instead.' % (' or '.join(c.__name__ for c in self.classes),
repr(value))) repr(value)))

4
src/c3nav/mapdata/management/commands/cleangeometries.py
View file

@ -13,6 +13,10 @@ class Command(BaseCommand):
for model in get_submodels(GeometryMixin): for model in get_submodels(GeometryMixin):
for instance in model.objects.all(): for instance in model.objects.all():
old_geom = instance.geometry.wrapped_geojson old_geom = instance.geometry.wrapped_geojson
if instance.geometry.is_empty:
print('Deleted %s' % instance)
instance.delete()
continue
instance.save() instance.save()
instance.refresh_from_db() instance.refresh_from_db()
if instance.geometry.wrapped_geojson != old_geom: if instance.geometry.wrapped_geojson != old_geom: