2025-summer/team-3
12
Fork 0
Code Issues Pull requests Projects Releases Activity

protected references should only contain protected references

Browse source
This commit is contained in:
Laura Klünder 2024-11-29 16:11:58 +01:00
parent 6c4a16fc45
commit c1f137ed11
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/c3nav/editor/changes.py
View file

@ -671,14 +671,13 @@ class ChangedObjectCollection(BaseSchema):
if not new_situation.remaining_operations_with_dependencies:
# nothing left to do, congratulations we did it!
done_situation = new_situation
print('DONE SITUATION:', done_situation)
break
if best_uids.get(new_situation.operation_uids, 1000000) <= len(new_situation.operations):
# we already reached this situation with the same or less amount of operations
continue
# todo: don't forget nullable references and unique values
if isinstance(new_operation, CreateObjectOperation):
# if an object was created it's no longer missing
new_situation.missing_objects.get(new_operation.obj.model, set()).discard(new_operation.obj.id)
@ -771,9 +770,12 @@ class ChangedObjectCollection(BaseSchema):
continue
if isinstance(remaining_operation.main_op, DeleteObjectOperation):
problem_obj.protected_references = done_situation.obj_references.get(
remaining_operation.main_op.obj.model, {}
)[remaining_operation.main_op.obj.id]
problem_obj.protected_references = {
found_ref for found_ref in done_situation.obj_references.get(
remaining_operation.main_op.obj.model, {}
)[remaining_operation.main_op.obj.id]
if found_ref.on_delete == "PROTECT"
}
# this will fail if there are no protected references because that should never happen
continue