2025-summer/team-3
12
Fork 0
Code Issues Pull requests Projects Releases Activity

don't cause unnecessary queries for initial_values

Browse source
This commit is contained in:
Laura Klünder 2017-06-13 23:13:28 +02:00
parent c2382c7a3b
commit d3ffbd55cd
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/c3nav/editor/wrappers.py
View file

@ -121,8 +121,10 @@ class ModelInstanceWrapper(BaseWrapper):
self._initial_values[field] = getattr(self._obj, field.name)
elif (field.many_to_one or field.one_to_one) and not field.primary_key:
if field.name in updates:
self._wrap_model(field.model).get(pk=updates[field.name])
self._initial_values[field] = getattr(self._obj, field.name)
obj = self._wrap_model(field.model).get(pk=updates[field.name])
setattr(self._obj, field.name, obj)
setattr(self._obj, field.attname, obj.pk)
self._initial_values[field] = getattr(self._obj, field.attname)
def __eq__(self, other):
if isinstance(other, BaseWrapper):
@ -164,10 +166,9 @@ class ModelInstanceWrapper(BaseWrapper):
for field, initial_value in self._initial_values.items():
new_value = getattr(self._obj, field.name)
if field.related_model:
new_pk = None if new_value is None else new_value.pk
initial_pk = None if initial_value is None else initial_value.pk
if new_pk != initial_pk:
self._changeset.add_update(self, name=field.name, value=new_pk, author=author)
new_value = None if new_value is None else new_value.pk
if new_value != initial_value:
self._changeset.add_update(self, name=field.name, value=new_value, author=author)
continue
if new_value == initial_value: