From ddcac55ba1a98e48aa7cb6362cf487a72c9d68e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laura=20Kl=C3=BCnder?= <laura@codingcatgirl.de>
Date: Thu, 12 Dec 2024 22:29:14 +0000
Subject: [PATCH] add view users permission

---
 ...015_userpermissions_view_users_and_more.py | 23 +++++++++++++++++++
 src/c3nav/control/models.py                   |  1 +
 src/c3nav/control/templates/control/base.html |  4 +++-
 src/c3nav/control/views/users.py              |  5 ++++
 4 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 src/c3nav/control/migrations/0015_userpermissions_view_users_and_more.py

diff --git a/src/c3nav/control/migrations/0015_userpermissions_view_users_and_more.py b/src/c3nav/control/migrations/0015_userpermissions_view_users_and_more.py
new file mode 100644
index 00000000..f322c779
--- /dev/null
+++ b/src/c3nav/control/migrations/0015_userpermissions_view_users_and_more.py
@@ -0,0 +1,23 @@
+# Generated by Django 5.0.8 on 2024-12-12 22:28
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('control', '0014_userpermissions_sources_access'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='userpermissions',
+            name='view_users',
+            field=models.BooleanField(default=False, verbose_name='view user list in control panel'),
+        ),
+        migrations.AlterField(
+            model_name='userpermissions',
+            name='max_changeset_changes',
+            field=models.PositiveSmallIntegerField(default=20, verbose_name='max changes per changeset'),
+        ),
+    ]
diff --git a/src/c3nav/control/models.py b/src/c3nav/control/models.py
index 156de764..7190e991 100644
--- a/src/c3nav/control/models.py
+++ b/src/c3nav/control/models.py
@@ -26,6 +26,7 @@ class UserPermissions(models.Model):
     manage_map_updates = models.BooleanField(default=False, verbose_name=_('manage map updates'))
 
     control_panel = models.BooleanField(default=False, verbose_name=_('can access control panel'))
+    view_users = models.BooleanField(default=False, verbose_name=_('view user list in control panel'))
     grant_permissions = models.BooleanField(default=False, verbose_name=_('can grant control permissions'))
     manage_announcements = models.BooleanField(default=False, verbose_name=_('manage announcements'))
     grant_all_access = models.BooleanField(default=False, verbose_name=_('can grant access to everything'))
diff --git a/src/c3nav/control/templates/control/base.html b/src/c3nav/control/templates/control/base.html
index 7fb9465d..ff2d54a2 100644
--- a/src/c3nav/control/templates/control/base.html
+++ b/src/c3nav/control/templates/control/base.html
@@ -16,7 +16,9 @@
     <nav>
         <p>
             <a href="{% url 'control.index' %}">{% trans 'Overview' %}</a> &middot;
-            <a href="{% url 'control.users' %}">{% trans 'Users' %}</a> &middot;
+            {% if request.user_permissions.view_users %}
+                <a href="{% url 'control.users' %}">{% trans 'Users' %}</a> &middot;
+            {% endif %}
             <a href="{% url 'control.access' %}">{% trans 'Access' %}</a> &middot;
             {% if request.user_permissions.manage_announcements %}
                 <a href="{% url 'control.announcements' %}">{% trans 'Announcements' %}</a> &middot;
diff --git a/src/c3nav/control/views/users.py b/src/c3nav/control/views/users.py
index 8d43c8d8..11367d9a 100644
--- a/src/c3nav/control/views/users.py
+++ b/src/c3nav/control/views/users.py
@@ -1,6 +1,7 @@
 from django.contrib import messages
 from django.contrib.auth.decorators import login_required
 from django.contrib.auth.models import User
+from django.core.exceptions import PermissionDenied
 from django.db import IntegrityError, transaction
 from django.db.models import Prefetch
 from django.shortcuts import get_object_or_404, redirect, render
@@ -21,6 +22,7 @@ class UserListView(ControlPanelMixin, ListView):
     template_name = "control/users.html"
     ordering = "id"
     context_object_name = "users"
+    user_permission = "view_users"
 
     def get_queryset(self):
         qs = super().get_queryset()
@@ -33,6 +35,9 @@ class UserListView(ControlPanelMixin, ListView):
 @login_required(login_url='site.login')
 @control_panel_view
 def user_detail(request, user):  # todo: make class based view
+    if not (request.user_permissions.view_users or user == request.user.pk):
+        raise PermissionDenied
+
     qs = User.objects.select_related(
         'permissions',
     ).prefetch_related(